-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass username/password to Cassandra docker-compose health check #6214
Pass username/password to Cassandra docker-compose health check #6214
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6214 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 354 354
Lines 20127 20127
=======================================
Hits 19418 19418
Misses 524 524
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this change, but I would like to understand what specifically it's fixing since our CI was fine without it. And if it fixes a real problem then why didn't our CI catch it before.
Replied in the issue linked. Thanks |
Signed-off-by: Alok Kumar Singh <[email protected]>
Signed-off-by: Alok Kumar Singh <[email protected]>
Signed-off-by: Alok Kumar Singh <[email protected]>
164aca2
to
c747574
Compare
Thanks |
Which problem is this PR solving?
Description of the changes
healthcheck_cassandra
point to make sure the container is healthy as per the cmd.How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test