-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kafka exporter and receiver configuration #5703
Conversation
Signed-off-by: joeyyy09 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5703 +/- ##
==========================================
+ Coverage 96.65% 96.66% +0.01%
==========================================
Files 342 342
Lines 16515 16515
==========================================
+ Hits 15962 15964 +2
+ Misses 363 362 -1
+ Partials 190 189 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, but we need e2e tests
Yeah, will get started on it! |
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Harshith Mente <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to add this new test to the gh workflow? I don't see how it's getting run now.
Yes, I'll be doing that |
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Signed-off-by: Yuri Shkuro <[email protected]>
I think we should merge this is the build is green. It's not running the e2e test, but we can add that in a separate PR. |
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Yeah sure, i'll open another PR for the e2e test |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test