-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: cassandra container never becomes healthy #6215
Comments
What about these CI runs on main? https://github.com/jaegertracing/jaeger/actions/runs/11843397266 |
This is because the health check is done here: https://github.com/jaegertracing/jaeger/blob/eb6c5c907d349667d9921b9722f39bdd8b97dcf1/plugin/storage/cassandra/schema/docker.sh#L28C1-L44C5 which is being used here: https://github.com/jaegertracing/jaeger/blob/eb6c5c907d349667d9921b9722f39bdd8b97dcf1/scripts/cassandra-integration-test.sh#L77C2-L79C1 So, when I tried to bypass |
## Which problem is this PR solving? - Resolves #6215 ## Description of the changes - Added the username and password values for health check cmd - Added `healthcheck_cassandra` point to make sure the container is healthy as per the cmd. ## How was this change tested? - bash scripts/cassandra-integration-test.sh 4 v004 v1 - bash scripts/cassandra-integration-test.sh 4 v004 v2 ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Alok Kumar Singh <[email protected]>
What happened?
Post addition of password-based authentication, the Cassandra container spawned by the docker-compose never becomes healthy. This is because the username and password is not provided to the health check cmd.
Upon checking health check stat using:
docker inspect --format "{{json .State.Health }}" "v4-cassandra-1" | jq
Steps to reproduce
docker compose -f "docker-compose/cassandra/v4/docker-compose.yaml" up -d
Expected behavior
healthy
status at some point and no authentication error logs.Relevant log output
Jaeger backend version
Both v1 and v2
Stogage backend
Cassandra v4
The text was updated successfully, but these errors were encountered: