Use Tries to match with the GLSL keywords #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly speeds up the keyword token matching by using simple Trie structure. Also the previous implementation unnecessarily looped through the keywords even if a match was already found and even tried to match them discarding the result (boolean short-circuiting done inefficiently).
I have a beast of a computer (14th gen Intel), I did this basic logging benchmark with a 87 LoC shader:
Old:
INFO [com.jme3.gde.glsl.highlighter.lexer.GlslKeywordLibrary]: Hits 1 389, total time spent 13ms
New:
INFO [com.jme3.gde.glsl.highlighter.lexer.GlslKeywordLibrary]: Hits 1 389, total time spent 0ms
(hits == how many times we enter the method, total time spent is cumulative time spent in the method)
So the speedup is a magnitude of infinite? Well, it is fast now.