Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getting started page #80

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Add getting started page #80

merged 2 commits into from
Oct 24, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Sep 8, 2024 •
edited
Loading

I have ported the "Getting Started" page to markdown and added required graphical assets. I did not exactly replicate the image placement from this page, but I think this is fine for now.

I also enabled embedding of HTML in markdown pages for the site.

@JeremyMcCormick JeremyMcCormick linked an issue Sep 8, 2024 that may be closed by this pull request
Add getting started page #62
Closed
@JeremyMcCormick JeremyMcCormick changed the title Add "Getting Started" page Add getting started page Sep 9, 2024
@gmantele
Copy link
Member

gmantele commented Sep 9, 2024

It is possible to get a nice zoom in effect with Hugo. I did it for all figures on the CDS website (ex: look at the 'Figure 1' on this page: https://cds.unistra.fr/blog/2024/02/20-a-new-look-for-the-cds-website/).

@molinaro-m
Copy link
Member

I think that the porting from this PR is enough for now, or maybe even too much.
I suppose that, once we have the .md website ready, we can rethink the structure of that page (maybe templating it together with similat ones).
I wouldn't spend more effort on this than what's already done.

molinaro-m
molinaro-m approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@molinaro-m molinaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page translation is fine for me

@molinaro-m
Copy link
Member

just for my understanding: why wasn't this merged?

@JeremyMcCormick
Copy link
Collaborator Author

just for my understanding: why wasn't this merged?

I need to do a little work on this for image placement and taking out some config I changed that allows raw HTML, which @gmantele suggested we should not enable, and I agree. I'm going to mark this as draft for now so it doesn't get merged before these fixes are made.

@JeremyMcCormick JeremyMcCormick marked this pull request as draft October 15, 2024 20:17
@JeremyMcCormick JeremyMcCormick force-pushed the iss62 branch 2 times, most recently from efe365f to 1531b23 Compare October 24, 2024 21:39
@JeremyMcCormick JeremyMcCormick marked this pull request as ready for review October 24, 2024 21:44
@JeremyMcCormick
Copy link
Collaborator Author

This looks a bit different from the old website but seems fine to me:

image

@JeremyMcCormick JeremyMcCormick removed the request for review from gmantele October 24, 2024 21:55
@JeremyMcCormick JeremyMcCormick merged commit c64e60f into main Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molinaro-m molinaro-m Awaiting requested review from molinaro-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getting started page
3 participants
@JeremyMcCormick @gmantele @molinaro-m