Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory issue in evaluation #230

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mohsen-ghaffari1992
Copy link
Collaborator

The simple maze trials are now longer which results in heap issues while evaluating. To see the results
testOnly symsim.examples.concrete.simplemaze.SarsaExperiments
If you did not see the heap issue, please try again. Because it is appearing when the learned policy has situation that timeout happens.

@wasowski
Copy link
Member

I must have a better JVM or more RAM, because this does not run out of memory for me. I will try to see whether I can make it run longer.

@wasowski wasowski removed their request for review January 10, 2024 19:39
@wasowski
Copy link
Member

@mohsen-ghaffari1992 I am confused. I am looking into src/test/scala/symsim/examples/concrete/simplemaze/SarsaExperiments.scala, but this file seems to run only 5 evaluation episodes. So I cannot understand how this can run out of memory for you?

@mohsen-ghaffari1992
Copy link
Collaborator Author

mohsen-ghaffari1992 commented Jan 10, 2024

@wasowski
I think you missed something. We translate all the Q-tables to policies. So, we evaluate it as long as number of episodes.
Five, is the number of times that each policy will be evaluated.

@wasowski
Copy link
Member

A ok. This makes sense. So for 10 000 episodes you get a crash during evaluation? (I can see that learning is still run in this example).

@mohsen-ghaffari1992
Copy link
Collaborator Author

Exactly!
As I said, it is possible that you evaluate few times and it does not crush. This is because of not facing many times with policies that most stop due to timeout. If this happens (most of the time agent stocks and need to wait until timeout), then heap get full and crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants