Fix docker vulnerabilites by upgrading node image (#551)

* fix: Dockerfile to reduce vulnerabilities (#29) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE315-ZLIB-2976173 - https://snyk.io/vuln/SNYK-ALPINE315-OPENSSL-3314621 - https://snyk.io/vuln/SNYK-ALPINE315-OPENSSL-3314622 - https://snyk.io/vuln/SNYK-ALPINE315-OPENSSL-3314629 - https://snyk.io/vuln/SNYK-ALPINE315-OPENSSL-3368753 Co-authored-by: snyk-bot <[email protected]> * Do rebase outside of the make instead * Use 22-alpine for docker --------- Co-authored-by: snyk-bot <[email protected]>
itteco · Aug 22, 2024 · c1b0459 · c1b0459
1 parent dfd5b7c
commit c1b0459
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,11 +1,11 @@
-FROM node:17.8-alpine3.15
+FROM node:22-alpine
 
 EXPOSE 8061
 
 WORKDIR /iframely
 
 # Create new non-root user
-RUN addgroup -S iframelygroup && adduser -S iframely -G iframelygroup
+RUN addgroup --system iframelygroup && adduser --system iframely -G iframelygroup
 RUN apk add g++ make python3
 
 # This will change the config to `config.<VALUE>.js` and the express server to change its behaviour.

diff --git a/Makefile b/Makefile
@@ -7,7 +7,6 @@ PUBLISHPORT := ${EXPOSEPORT}
 
 build:
 	git checkout main 
-	git pull --rebase upstream main
 	git branch -f tag-${VERSION}
 	git checkout tag-${VERSION}
 	docker \