Skip to content
This repository has been archived by the owner on May 18, 2024. It is now read-only.

Artificial sorting #30

Open
wants to merge 561 commits into
base: master
Choose a base branch
from
Open

Artificial sorting #30

wants to merge 561 commits into from

Conversation

itsToggle
Copy link
Owner

No description provided.

ncw and others added 30 commits October 14, 2022 11:11
It was discovered that doing the tls Handshake immediately on
connection causes some FTP servers (proftpd and pureftpd) to hang.

This imports a fix for it by temporarily hard forking jlaffaye/ftp to
include the fix submitted as a pull request.

See: https://forum.rclone.org/t/rclone-ftps-explicit-rclone-touch-empty-files-proftpd-unable-to-build-data-connection-operation-not-permitted/22522
See: rclone#6426 (comment)
See: jlaffaye/ftp#283
See: jlaffaye/ftp#282
…s for HTTP servers

This allows administrators to disable TLS 1.0 and 1.1, for example.

Example:

rclone rcd --rc-min-tls-version=tls1.2 --rc-cert <cert> --rc-key <key>
Updated FAQ to clarify that experimental bi-sync is now available.
This fixes vulnerability GO-2022-0969 reported by govulncheck:

HTTP/2 server connections can hang forever waiting for a clean
shutdown that was preempted by a fatal error. This condition can
be exploited by a malicious client to cause a denial of service.

Call stacks in your code:
Error: cmd/serve/restic/restic.go:150:22: github.com/rclone/rclone/cmd/serve/restic.init$1$1 calls golang.org/x/net/http2.Server.ServeConn

Found in: golang.org/x/net/[email protected]
Fixed in: golang.org/x/net/[email protected]
More info: https://pkg.go.dev/vuln/GO-2022-0969
The API endpoint GetBucketLocation requires
top level permission.

If we do an authenticated head request to a bucket, the bucket location will be returned in the HTTP headers.

Fixes rclone#5066
//
func (f *Fs) move(ctx context.Context, isFile bool, id, oldLeaf, newLeaf, oldDirectoryID, newDirectoryID string) (err error) {
// fs.LogPrint(fs.LogLevelDebug, "move locking file_mutex")
file_mutex.Lock()
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are never written into the file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.