Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of this #286, happy to discuss.
This PR adds:
Notes:
The line
token := c.Request.Header.Get("apitoken")
is IMO missleading: the actual header is "Apitoken" because it's canonical-ified, and thus is equal totoken := c.Request.Header.Get("Apitoken")
(note the capital A)What do you think about updating it to the last one to match what's the user is supposed to provide? (
Apitoken
and notapitoken
)