10.0 access restricted #66

iledarn · 2017-11-06T15:37:37Z

No description provided.

…ow_apps

…from_settings - any modules may be installed through Odoo API using xmlrpc, redefine `_install_modules` of `res.config.settings` instead - underscore methods cannot be accessed through xmlrpc

…rs of group `allow add from settings`

…o add groups from settings menu

yelizariev · 2017-11-15T10:19:23Z

We probably need to imply Adminstration / Settings rights when user has access Allow add implied groups from settings, otherwise latter doesn't have sense, because user doens't have access to Settings. see https://github.com/it-projects-llc/access-addons/pull/66#discussion_r151070397

….group_system - if we allow to add grups from settings then we should give rights to open the settings menu

yelizariev · 2017-11-16T06:18:05Z

For squashed commit:

[ADD] set of updates


access_apps:

`1.2.0`
-------

- REF: rename "Show Apps Menu" to "Allow install apps"
- ADD: "Allow install apps only from settings"
- IMP: group "Show Apps Menu" and "Allow install apps only from settings" under "Apps access" security category
 

access_restricted:

`1.3.0`
-------

- [ADD] security group that allows increasing rights from settings menu (by checking ``res.config.settings`` 'group_XXX' boolean fields)

yelizariev · 2017-11-16T06:19:00Z

write tests for new features of access_restricted (User has access -> no errors, User has not access -> error is raised)

yelizariev · 2017-11-16T06:27:17Z

test that non-super admin don't see unavailable fields (groups)
- emulate opening of res.user form -- repeat calls that browser does via xmlrpc when you open view manulally via interface
- add new groups to users and open form again -- new group must be appeared at the form

yelizariev

More tests are required

iledarn · 2017-11-23T09:27:58Z

@yelizariev please check 329739d for > test that non-super admin don't see unavailable fields (groups)

iledarn · 2017-11-29T12:09:57Z

@yelizariev

We probably need to imply Adminstration / Settings rights when user has access Allow add implied groups from settings, otherwise latter doesn't have sense, because user doens't have access to Settings

Implying the 'Administration / Settings' is excessive.
Access to see a specific settings menu may be given by a custom security group. In other words, we shouldn't give a user full administration privileges just to make him able to open a specific menu item

…for base.group_system - if we allow to add grups from settings then we should give rights to open the settings menu" This reverts commit 866e84a.

iledarn · 2017-12-04T09:42:05Z

@yelizariev ,

write tests for new features of access_restricted (User has access -> no errors, User has not access -> error is raised)

This is also done, please merge

yelizariev · 2017-12-04T11:49:12Z

access_restricted/tests/test_allow_implied.py

+        self.assertTrue(test_config_settings._get_classified_fields()['group'])
+
+        test_config_settings.sudo(demo_user.id).execute()
+        self.assertTrue(self.env['res.users'].sudo(demo_user.id).has_group('base.group_user'))


Add check that demo user doesn't have group_user before calling execute()

…p_user

iledarn · 2017-12-04T14:46:12Z

@yelizariev

close #66 > Made via .github/workflows/DINAR-PORT.yml

Ildar Nasyrov added 28 commits October 30, 2017 12:50

[ADD] access_apps: "Allow install apps only from settings"

7d8eace

[DOC] access_apps

d5013a1

[LINT] access_apps

fe1531c

[DOC] access_apps

e118413

[DOC] access_apps

fe7c868

[DOC] access_apps

e7d7d3c

[DOC] access_apps

32cd0b6

[DOC] access_apps

cd1331b

[DOC] access_apps

b402115

[REF] access_apps_website, apps: group_show_modules_menu -> group_all…

00eb443

…ow_apps

[IMP] access_apps: do not grant full access to group_allow_apps_only_…

32ff0b1

…from_settings - any modules may be installed through Odoo API using xmlrpc, redefine `_install_modules` of `res.config.settings` instead - underscore methods cannot be accessed through xmlrpc

[DOC] access_apps

29a3b81

[DOC] access_apps

e6d7b97

[DOC] access_apps

823735d

[IMP] access_apps: avoid copy-pasting

31a8dc7

[LINT] access_apps

38b9aec

[IMP] access_restricted: move security data into security folder

3587328

[ADD] access_restricted: allow add groups from settings menu to membe…

7e6b7ce

…rs of group `allow add from settings`

[ADD] access_restricted: allow users in group allow add implied.. t…

0610340

…o add groups from settings menu

[IMP] access_restricted: better name for security group

d4a2f1b

[DOC] access_restricted

b340645

[DOC] access_restricted

3d8dd58

[DOC] access_restricted

a989fbf

[DOC] access_restricted

ef8deae

[DOC] access_restricted

5834bc4

[DOC] access_restricted

7ab6db6

[DOC] access_restricted

432a9cf

[DOC] access_restricted

cc2999e

iledarn mentioned this pull request Nov 7, 2017

10.0 access_apps #63

Closed

[DOC] access_apps_website

f754785

[IMP] access_restricted: all settings menu in only available for base…

866e84a

….group_system - if we allow to add grups from settings then we should give rights to open the settings menu

yelizariev approved these changes Nov 16, 2017

View reviewed changes

yelizariev requested changes Nov 16, 2017

View reviewed changes

[CI] access_restricted: test on fields_get

329739d

[CI] access_restricted: test fields_get

e5f7811

Ildar Nasyrov added 4 commits November 29, 2017 12:29

Revert "[IMP] access_restricted: all settings menu in only available …

325262e

…for base.group_system - if we allow to add grups from settings then we should give rights to open the settings menu" This reverts commit 866e84a.

[IMP] access_restricted: file structure

525ac2a

[ADD] access_restricted: test for implied groups

3834de6

[CI] access_restricted

971534d

Ildar Nasyrov added 4 commits December 4, 2017 10:29

[CI] access_restricted: _update_user_groups_view

4ae1fcd

[CI] access_restricted

c6042dd

[CI] access_restricted: sudo _update_user_groups_view

e656226

[CI] access_restricted

b61de95

yelizariev requested changes Dec 4, 2017

View reviewed changes

Ildar Nasyrov added 6 commits December 4, 2017 12:20

[CI] access_restricted test_allow_implied: make sure there is no grou…

dcdc0f7

…p_user

[CI] access_restricted

5836400

[CI] access_restricted

49e61f0

[CI] access_restricted

b86b3c7

[LINT] access_restricted

327add9

[CI] access_restricted

cb755b0

yelizariev merged commit 540597a into itpp-labs:10.0 Dec 5, 2017

yelizariev pushed a commit that referenced this pull request May 13, 2024

⬆️1️⃣7️⃣ OCA/odoo-module-migrator

705e680

close #66 > Made via .github/workflows/DINAR-PORT.yml

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

10.0 access restricted #66

10.0 access restricted #66

iledarn commented Nov 6, 2017 •

edited

Loading

yelizariev commented Nov 15, 2017

yelizariev commented Nov 16, 2017

yelizariev commented Nov 16, 2017 •

edited

Loading

yelizariev commented Nov 16, 2017 •

edited

Loading

yelizariev left a comment

iledarn commented Nov 23, 2017

iledarn commented Nov 29, 2017 •

edited

Loading

iledarn commented Dec 4, 2017

yelizariev Dec 4, 2017

iledarn commented Dec 4, 2017

10.0 access restricted #66

10.0 access restricted #66

Conversation

iledarn commented Nov 6, 2017 • edited Loading

yelizariev commented Nov 15, 2017

yelizariev commented Nov 16, 2017

yelizariev commented Nov 16, 2017 • edited Loading

yelizariev commented Nov 16, 2017 • edited Loading

yelizariev left a comment

Choose a reason for hiding this comment

iledarn commented Nov 23, 2017

iledarn commented Nov 29, 2017 • edited Loading

iledarn commented Dec 4, 2017

yelizariev Dec 4, 2017

Choose a reason for hiding this comment

iledarn commented Dec 4, 2017

iledarn commented Nov 6, 2017 •

edited

Loading

yelizariev commented Nov 16, 2017 •

edited

Loading

yelizariev commented Nov 16, 2017 •

edited

Loading

iledarn commented Nov 29, 2017 •

edited

Loading