Remove mutli source encoding cache (#4678)

iterative · Sep 18, 2023 · 8f6d2a3 · 8f6d2a3
1 parent 7163616
commit 8f6d2a3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/extension/src/plots/model/index.ts b/extension/src/plots/model/index.ts
@@ -415,7 +415,7 @@ export class PlotsModel extends ModelWithPersistence {
       await Promise.all([
         collectData(output),
         collectTemplates(output),
-        collectMultiSourceVariations(output, this.multiSourceVariations)
+        collectMultiSourceVariations(output)
       ])
 
     this.comparisonData = {

diff --git a/extension/src/plots/multiSource/collect.ts b/extension/src/plots/multiSource/collect.ts
@@ -85,10 +85,8 @@ const collectPathMultiSourceVariations = (
   }
 }
 
-export const collectMultiSourceVariations = (
-  output: PlotsOutput,
-  acc: Record<string, Record<string, unknown>[]>
-) => {
+export const collectMultiSourceVariations = (output: PlotsOutput) => {
+  const acc: Record<string, Record<string, unknown>[]> = {}
   const { data } = output
   for (const [path, plots] of Object.entries(data)) {
     collectPathMultiSourceVariations(acc, path, plots)
@@ -275,6 +273,8 @@ const collectUnmergedShapeEncoding = (
   }
 }
 
+// this is how we can collect the encoding for multi-source plots
+// we need to pass in the anchors that we want to fill as well
 const collectPathMultiSourceEncoding = (
   acc: MultiSourceEncoding,
   path: string,