-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing templating vars inside range context #47
Conversation
Also, let's leave out |
Hmm, Goes against most PR titling practices I've ever seen actually in any public (or private repo). There's usually some prefix convention (fix, bugfix, chore, feat, something..) |
fb2c60d
to
d524fc2
Compare
I've seen thousands of projects not using any prefixes or annotations in their PR titles and commit messages. Anyway, it would be nice to introduce prefixes or Conventional Commits. We've tried to set up the latter but ran into some issues. The difficulty lies in ensuring that every contributor's commits conform to the standard, hence the need for additional safeguards like pre-commit and CI jobs. Let's follow up here #50 |
@jesper7 - standardization aside, not sure I'm on the same page wrt |
Not relevant anymore - range loop removed |
Inside
.range
context for vars changes, we need$
to refer to top level (for.Release
or.Values
)