Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing templating vars inside range context #47

Closed
wants to merge 3 commits into from

Conversation

omesser
Copy link
Contributor

@omesser omesser commented Jan 14, 2023

Inside .range context for vars changes, we need $ to refer to top level (for .Release or .Values)

@omesser omesser added the bug Something isn't working label Jan 14, 2023
@omesser omesser requested review from jesper7 and mjasion January 14, 2023 18:43
@omesser omesser changed the title Bugfix - Fix context for templating values inside range Bugfix - templating vars / fix context inside range Jan 15, 2023
charts/studio/values.yaml Outdated Show resolved Hide resolved
@jesper7
Copy link
Contributor

jesper7 commented Jan 16, 2023

Also, let's leave out bugfix in the PR title. Otherwise, it gets duplicated in the changelog 🙂

@omesser
Copy link
Contributor Author

omesser commented Jan 16, 2023

Also, let's leave out bugfix in the PR title. Otherwise, it gets duplicated in the changelog 🙂

Hmm, Goes against most PR titling practices I've ever seen actually in any public (or private repo). There's usually some prefix convention (fix, bugfix, chore, feat, something..)
So something to think about I believe -
It's coming from keeping the commit log readable - I think the git history is probably more important then possible duplication of the word on the release changelog 🤔 . Also changelog sections might not correspond to this internal classification of change requests.

@omesser omesser requested a review from jesper7 January 16, 2023 13:07
@jesper7
Copy link
Contributor

jesper7 commented Jan 16, 2023

Hmm, Goes against most PR titling practices I've ever seen actually in any public (or private repo). There's usually some prefix convention (fix, bugfix, chore, feat, something..)

I've seen thousands of projects not using any prefixes or annotations in their PR titles and commit messages.

Anyway, it would be nice to introduce prefixes or Conventional Commits. We've tried to set up the latter but ran into some issues. The difficulty lies in ensuring that every contributor's commits conform to the standard, hence the need for additional safeguards like pre-commit and CI jobs. Let's follow up here #50

@omesser omesser changed the title Bugfix - templating vars / fix context inside range Fixing templating vars inside range context Jan 16, 2023
@omesser
Copy link
Contributor Author

omesser commented Jan 16, 2023

@jesper7 - standardization aside, not sure I'm on the same page wrt Bugfix - prefix being detrimental (even if not standardized, as long as there's no OTHER standard).
However - this is a minor peeve. title changed - I'd like to commit all the helm changes so I can test them asap

@omesser
Copy link
Contributor Author

omesser commented Jan 16, 2023

Not relevant anymore - range loop removed

@omesser omesser closed this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants