make hf tests work #833
Merged
make hf tests work #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dberenbaum
commented
Jul 10, 2024
| @@ -103,6 +103,7 @@ def args(): | |||
| num_train_epochs=2, | |||
| save_strategy="epoch", | |||
| report_to="none", # Disable auto-reporting to avoid duplication | |||
| use_cpu=True, | |||
There was a problem hiding this comment.
Tests were failing locally for me because hf was using my m1 mps device
dberenbaum
commented
Jul 10, 2024
| @@ -57,7 +57,7 @@ tests = [ | |||
| "pytest_voluptuous", | |||
| "dpath", | |||
| "transformers[torch]", | |||
| "keras<3" | |||
| "tf-keras" | |||
There was a problem hiding this comment.
See #832 (comment). This should work in huggingface while still allowing us to run keras tests with keras 3.
shcheklein
approved these changes
Jul 10, 2024
dberenbaum
pushed a commit
that referenced
this pull request
Jul 10, 2024
* build(deps): bump mypy from 1.10.0 to 1.10.1 Bumps [mypy](https://github.com/python/mypy) from 1.10.0 to 1.10.1. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.10.0...v1.10.1) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * remove aliase classes * drop catalyst * make hf tests work (#833) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivan Shcheklein <[email protected]> Co-authored-by: Dave Berenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shcheklein Added a couple minor changes to your PR