Use DVC_ROOT to detect pipeline
#718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
dberenbaum
force-pushed
the
dvc-root
branch
from
4d77512 to
8d8ee60
Compare
|
@iterative/dvc Can anyone take a look at this please? |
efiop
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
DVC_ROOT, we often checked for whether dvclive was running insidedvc exp runbecause we had no way to check whether running insidedvc repro, but often we really want the same behavior in both scenarios. This PR expands the use ofDVC_ROOTto check whether dvclive is running inside a pipeline.