3.0 updates #684
Merged
3.0 updates #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Let's wait a few days on this since there is no rush and want to make sure we don't forget something. Then we can merge at the start of next week if nothing comes up. |
|
We also need accompanying docs updates. |
dberenbaum
previously requested changes
Aug 25, 2023
There was a problem hiding this comment.
Nothing wrong with the PR AFAICT, but let's hold on this for #687
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
* add dvcyaml to root * clean up dvcyaml implementation * fix existing tests * add new tests * add unit tests for updating dvcyaml * use posix paths * don't resolve symlinks * drop entire dvclive dir on cleanup * fix studio tests * revert cleanup changes * unify rel_path util func * cleanup test * refactor tests * add test for multiple dvclive instances * put dvc_file logic into _init_dvc_file --------- Co-authored-by: daavoo <[email protected]>
Fallback to `None` when conditions are not met for other types.
Rename test_frameworks to frameworks.
|
@dberenbaum should we just merge this into main? I don't think there is reason to wait and unlikely needing to release 2.X |
|
I was thinking of waiting on iterative/dvc#9898 since if we have to release before then, it will be ugly for existing projects |
|
Need to update dvc version before merging |
* drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * dvc version bump
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #499
Closes #484
Closes #459