Fill template anchors inside custom template strings #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Oct 5, 2023
| src = f"data:image/png;base64,{base64_str}" | ||
|
|
||
| return f"\n" | ||
| if x is not None and y is not None: |
There was a problem hiding this comment.
[F] I came across the same issue in #142. The error only happens in the CI. Please LMK if you want me to split this into another PR.
mattseddon
changed the title
dberenbaum
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28
This PR makes it possible for users to add anchors into strings for calculation purposes in custom templates.
Note: As this is close to a 1 line change and is non-breaking it makes more sense to split it out from #142.