Order image per step plots #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
order-image-per-step
branch
2 times, most recently
from
d33e0eb to
3c55856
Compare
mattseddon
force-pushed
the
order-image-per-step
branch
from
3c55856 to
d81a40e
Compare
mattseddon
commented
Sep 14, 2023
| is_image_renderer = isinstance(renderer, ImageRenderer) | ||
|
|
||
| if not is_image_renderer: | ||
| return (is_image_renderer, None, None, None) |
There was a problem hiding this comment.
IIUC having this here will stop the code from reordering VegaRenderers.
shcheklein
approved these changes
Sep 14, 2023
|
Thanks @mattseddon! I wouldn't spend time fixing the html any more per the discussion in iterative/dvc#9940. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this one whilst working on iterative/dvc#9940
This PR fixes a bug in the HTML. Previously "image per step" images where not ordered correctly due to their paths being treated as strings.
Before
Screen.Recording.2023-09-14.at.8.23.10.pm.mov
After
Screen.Recording.2023-09-14.at.8.21.34.pm.mov
Note: don't ask for a slider.