Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!] 底部单击添加颜色变化,暴露tab单击事件,封装AppBar,底部tab通过传参数配置 #23

Merged
merged 5 commits into from
Jul 25, 2019

Conversation

wjun94
Copy link
Contributor

@wjun94 wjun94 commented Jul 24, 2019


CheckList

Thanks for considering to this repository. Before you submit your issue, please confirm these boxes are checked.

  • I have read 《[EN]Style guide for Flutter repo [CN]Flutter项目代码规范、规约选型》.
  • 我遵守以下 Merge 规则:PR提交后,邀请群组中任意一人进行 review,即可合并。让 reviewer 在 PR 所在页面写下 review 意见表示通过,即可合并。最简单写一句 LGTM 也可以。不按照本规则执行,自己 PR 自己 Merge 并引入问题,会被收回 Merge 权限。

My issue:

What I have done:

@ChenYilong
Copy link
Member

合并后,app demo样式的截图贴一下,尤其是iPhoneX上的适配情况。

@wjun94
Copy link
Contributor Author

wjun94 commented Jul 24, 2019

image

@ChenYilong
Copy link
Member

没适配iPhoneX,请适配完。一起合并。

@ChenYilong
Copy link
Member

没适配iPhoneX,先合并了,下次一起适配下。

@ChenYilong ChenYilong merged commit ef54730 into iteatimeteam:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants