Add in_response_to from saml_session to SAML2 validator #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brunato feel free to merge dev into main branch and please go ahead with a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the failed CI tests of PR #55.
The request ID is extracted from saml_session's cache an provided to Saml2ResponseValidator with the option in_response_to (into method
djangosaml2_spid.views.AssertionConsumerServiceView.custom_validation()).I left a comment about the opportunity to filter cache's values on destination path (/spid/echo_attributes), particularly if the cache contains more values. Currently this is not clear to me.