Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase voxel size to improve ICP test reliability #7107

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

benjaminum
Copy link
Contributor

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

This is an attempt to make Registration/RegistrationPermuteDevices.ICPColored/0 more reliable.
Before the change we get 4 out of 100 test runs failed.
With the increased voxel size 0 out of 100 runs failed.

Copy link

update-docs bot commented Dec 19, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@benjaminum benjaminum requested a review from ssheorey December 20, 2024 10:37
@ssheorey ssheorey merged commit 34d8039 into main Dec 20, 2024
42 of 45 checks passed
@ssheorey ssheorey deleted the bu/flaky_registration_test branch December 20, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants