Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] threthold tolerance error (#6550) #6608

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

chunibyo-wly
Copy link
Contributor

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

fix #6550

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Here is the Merge result on this data without tolerance. The coplanar patches didn't be merged. The reason is normal deviate diff threshold is $1$, and the dot product of direcation normal (plane patches) would be $1$ too. So the robust planar test will fail on this.

And also the box size need to be large than zero, but for ideal points, it maybe calculated to zero. So we need to set a tolerance on this too.

the final result on this data

Copy link

update-docs bot commented Jan 17, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chunibyo-wly for this bug fix! Looks good.

@ssheorey ssheorey merged commit 74df0a3 into isl-org:main Mar 19, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detect_planar_patches fails with perfectly flat surfaces
2 participants