Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error in Articulation where default_joint_stiffness and default_joint_damping is not correctly set if actuator is instance of ImplicitActuator #1580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zoctipus
Copy link
Contributor

Description

Before the fix, the field, default_joint_stiffness, and default_joint_damping in omni.isaac.lab.assets.Articulation will be
the default value configured Joint Drive property in usd file, and defining a new value with actuator config will not have effect
if the actuator is type ImplicitActuator

after the fix, all actuator types will be able to override default_joint_stiffness and default_joint_damping

Fixes #1552

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

…_joint_damping is not correctly set if actuator is instance of ImplicitActuator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Articulation's default_joint_stiffness doesn't get set by code if Implicit Actuator is used
1 participant