Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests #138

Merged
merged 21 commits into from
Feb 7, 2024
Merged

Add integration tests #138

merged 21 commits into from
Feb 7, 2024

Conversation

ushabelgur
Copy link
Contributor

@ushabelgur ushabelgur commented Jan 24, 2024 •
edited by sujeet01
Loading

Proposed Changes

  • Start a ceph cluster using microceph inside GH runner
  • Add integration test for DeleteMachine
  • Add integration test for ListMachines
  • Add integration test for UpdateMachineAnnotations
  • Add integration test for UpdateMachinePower
  • Add integration test for Status
  • Add integration test for AttachVolume & DetachVolume
  • Add integration test for AttachNetworkInterface & DetachNetworkInterface

@ushabelgur ushabelgur added integration-tests to run integration tests and removed size/XL labels Jan 24, 2024
@github-actions github-actions bot added enhancement New feature or request server size/XL labels Jan 24, 2024
@ushabelgur ushabelgur force-pushed the enh/integration-tests branch 2 times, most recently from 563a336 to ff75686 Compare January 24, 2024 08:35
@kasabe28 kasabe28 force-pushed the enh/integration-tests branch 2 times, most recently from fe7d1ac to 09108ba Compare January 24, 2024 09:03
@ushabelgur ushabelgur marked this pull request as ready for review January 24, 2024 10:19
@ushabelgur ushabelgur requested a review from a team as a code owner January 24, 2024 10:19
@ushabelgur ushabelgur marked this pull request as draft January 24, 2024 11:10
@sujeet01 sujeet01 force-pushed the enh/integration-tests branch from 09108ba to aca4869 Compare January 24, 2024 18:06
@github-actions github-actions bot added size/XXL and removed size/XL labels Jan 24, 2024
@sujeet01 sujeet01 force-pushed the enh/integration-tests branch 7 times, most recently from 914fe6e to 41fed7f Compare January 24, 2024 20:01
@sujeet01 sujeet01 marked this pull request as ready for review January 24, 2024 20:55
@sujeet01 sujeet01 force-pushed the enh/integration-tests branch 2 times, most recently from 0c98c9a to fbdf230 Compare January 25, 2024 06:53
lukas016
lukas016 requested changes Jan 25, 2024
View reviewed changes
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yml Show resolved Hide resolved
provider/server/machine_annotations_update_test.go Show resolved Hide resolved
provider/server/machine_create_test.go Show resolved Hide resolved
provider/server/machine_volume_detach_test.go Outdated Show resolved Hide resolved
provider/server/machine_volume_detach_test.go Show resolved Hide resolved
provider/server/status_test.go Show resolved Hide resolved
provider/server/status_test.go Show resolved Hide resolved
provider/server/server_suite_test.go Outdated Show resolved Hide resolved
@kasabe28 kasabe28 requested a review from lukas016 January 29, 2024 10:19
@Rohit-0505 Rohit-0505 marked this pull request as draft January 29, 2024 10:59
@kasabe28 kasabe28 force-pushed the enh/integration-tests branch from 713af68 to 2d08fb3 Compare January 29, 2024 12:31
Rohit-0505 and others added 21 commits February 7, 2024 14:56
@Rohit-0505 @kasabe28
Add test cases for DeleteMachine and ListMachine
86195d2 
Signed-off-by: Rohit Kumar <[email protected]>
@ushabelgur @kasabe28
Add integration tests for update annotation and powerstate update
511d5f3 
Signed-off-by: Rohit Kumar <[email protected]>
@Rohit-0505 @kasabe28
remove extra assertions from delete and list machies test
07193ec 
Signed-off-by: Rohit Kumar <[email protected]>
@sujeet01 @kasabe28
Add integration tests for Status
08e8b53
@kasabe28
rebase with main and modify CreateMachine test for Volumes
6bae9b0
@kasabe28
Add integration tests for AttachVolume and DetachVolume
baaaeac
@kasabe28
Allow to read keyring file to ceph user in integration test workflow
bd38c24
@kasabe28
Modify AttachVolume and DetachVolume tests
1f296fa
@sujeet01 @Rohit-0505 @kasabe28
Add integration tests for AttachNetworkInterface and `DetachNetwork…
c587ef1 
…Interface`

Co-authored-by: Rohit Kumar <[email protected]>
@sujeet01 @kasabe28
Cleanup and update tests
f47ddf7
@ushabelgur @kasabe28
incorporating review comments
543ddbe
@kasabe28
address review comments
d88a065
@kasabe28
Add test for create machine after fixing #115
00a8e61
@ushabelgur @kasabe28
address review comments
eaa34da
@Rohit-0505 @kasabe28
address review comments
34f0ad8
@ushabelgur @kasabe28
updating microceph to latest stable version
56f60b9
@kasabe28
Modify DetachVolume test to detach ceph volume also
e0bf310
@ushabelgur @kasabe28
addressing review comments
950a1cc
@ushabelgur @kasabe28
addressing review comments
b388421
@ushabelgur @kasabe28
addresing review comments
9d1da71
@kasabe28
address review comments
e9c9f57
@kasabe28 kasabe28 dismissed stale reviews from afritzler and so-sahu via e9c9f57 February 7, 2024 09:28
@kasabe28 kasabe28 force-pushed the enh/integration-tests branch from 579688e to e9c9f57 Compare February 7, 2024 09:28
@lukasfrank lukasfrank mentioned this pull request Feb 7, 2024
Closed
@lukasfrank lukasfrank merged commit c000818 into main Feb 7, 2024
8 checks passed
@lukasfrank lukasfrank deleted the enh/integration-tests branch February 7, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasabe28 kasabe28 kasabe28 left review comments

@Rohit-0505 Rohit-0505 Rohit-0505 left review comments

@lukas016 lukas016 lukas016 approved these changes

@lukasfrank lukasfrank lukasfrank approved these changes

@so-sahu so-sahu so-sahu left review comments

@afritzler afritzler afritzler left review comments

Assignees
No one assigned
Labels
enhancement New feature or request integration-tests to run integration tests server size/XXL
Projects
Compute
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ushabelgur @afritzler @lukasfrank @lukas016 @Rohit-0505 @so-sahu @kasabe28 @sujeet01