(feat) Log errors #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @adamreeve, my changes have landed, so you should be able to update your PR now! |
adamreeve
force-pushed
the
feat/log-errors
branch
from
54e1f87 to
40a258b
Compare
|
Sorry for sitting on this, this looks great. Thank you very much! |
|
This doesn't completely address #58 as it still doesn't actually log the actual error, just the response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #58
I've made this change on top of zmbush's fixes in #57 which get logger working with the latest iron. I can tidy this PR up once that PR is merged.