Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS icons for graphical desktop clients #381

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

progval
Copy link
Contributor

@progval progval commented Jun 2, 2021

This doesn't add icons to Terminal Clients, so this PR does not conflict with #380

I'll add them if we decide to merge this PR before #380.

Note that the "freebsd" icon isn't displayed because we use FontAwesome 4, and it was added in FontAwesome 5.

@DanielOaks
Copy link
Member

I don't mind this but let me look into the table changes first (it's a tiny bit unwieldy with the current layout). I may split this into a separate column depending on stickyness of the top/left headers

@progval
Copy link
Contributor Author

progval commented Jun 2, 2021

Sure, no hurry

I'm not adding them for glirc or BitchX, because their
websites are (respectively) not providing the info and broken.
@DanielOaks
Copy link
Member

We'll need to update FontAwesome to get the bsd icon but we can worry about that later.

For now could you add this to _swtable.scss just under where the other os support colours are:

.os-support-macos {
    color: #444;
}
.os-support-windows {
    color: #4d75b3;
}
.os-support-linux {
    color: #826d2e;
}
.os-support-bsd {
    color: #a42f2f;
}

bitchx and swirc both support all of the OSes, according to their websites/install instructions.

I think Glirc supports all of them as well?

@SadieCat
Copy link
Contributor

It's probably fine to just group BSD and Linux under a general "UNIX" category.

@progval progval closed this Nov 23, 2021
@progval progval deleted the os-icons branch November 23, 2021 18:30
@progval progval restored the os-icons branch November 23, 2021 18:31
@progval progval reopened this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants