Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta PR - changes from private branch to be pulled in #155

Closed
wants to merge 1 commit into from

Conversation

dalehamel
Copy link
Member

@dalehamel dalehamel commented May 27, 2021

This is not in a mergeable state, this is just to share and discuss some of the changes we've done.

In order to move faster, this work was developed collaboratively on a private branch, prioritizing prototyping and building out features over a clean commit history. The branch history contains work that was reverted, and there isn't any need to clutter the public history with this. The branch has also diverged a bit with the current master branch.

It will take a bit of time to cut this up into smaller, more reviewable PRs and while maintaining attribution for authorship. Rather than delay on making these changes available, this is the full file-based diff of the changes, which encompass:

  • A complete overhaul of the integration test suite, adding support for minikube and KiND backends, and using buildkit to optimize image builds.

    • All tests run in their own k8s namespace, so it saves on set up / teardown time to just reuse a cluster locally
  • Support for process selectors, which can be used to pick a process to target for tracing more dynamically

  • Start of a "trace uploader" which is called after a trace succeeds right now.

    • Currently only supports GCS, though it should be trivial to add S3, azure backends, we just started with GCS.
  • Generic tracers, the latest version of the work from feat: Refactor bpftrace functionality to generic tracer #136

    • We've added rbspy as the first generic tracer besides bcc, but have several others we'd like to add soon.

    Note also https://github.com/dalehamel/kubectl-trace/pull/1/files which builds on this and is the initial operator support for Idea - kubectl-trace operator #85

@dalehamel dalehamel changed the title WIP pull changes from shopify Meta PR - changes from private branch to be pulled in May 27, 2021
@tsunamishaun
Copy link

hey @dalehamel! Excited to see all of these land as it would be a game changer for us, especially the operator/upload capabilities. Thanks for putting in all the work to make this happen.

@fntlnz fntlnz requested review from leodido and fntlnz June 17, 2021 11:29
@dalehamel
Copy link
Member Author

These have all landed, there are some other things i'll be following up with but I'm going to close this off.

@dalehamel dalehamel closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants