test: add NFT deposit estimation cluster test #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgemmsilva
commented
Sep 27, 2023
jorgemmsilva
commented
- enables gasburnlog on ISC estimategas calls
- NFTL1Mint functionality for cluster tests
- new test
dessaya
approved these changes
Sep 27, 2023
| @@ -31,7 +31,7 @@ func runISCTask( | |||
| TimeAssumption: blockTime, | |||
| Entropy: hashing.PseudoRandomHash(nil), | |||
| ValidatorFeeTarget: accounts.CommonAccount(), | |||
| EnableGasBurnLogging: false, | |||
| EnableGasBurnLogging: estimateGasMode, | |||
There was a problem hiding this comment.
This will use extra memory in production, right? But the burn log is never logged or returned to the caller...
There was a problem hiding this comment.
very little extra memory. it will on the chain/estimate-gas endpoint. will DM an example
jorgemmsilva
force-pushed
the
impr/misc
branch
from
4f17e55 to
28ff044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.