Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make WriteBytes size smaller #2888

Closed
wants to merge 1 commit into from
Closed

fix: Make WriteBytes size smaller #2888

wants to merge 1 commit into from

Conversation

howjmay
Copy link
Member

@howjmay howjmay commented Sep 23, 2023

No description provided.

jorgemmsilva
jorgemmsilva suggested changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@jorgemmsilva jorgemmsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently uint32 because that's required in some places iirc

@kape1395
Copy link
Collaborator

Indeed.

@howjmay
Copy link
Member Author

howjmay commented Sep 25, 2023

@jorgemmsilva uploading blob needs uint32. I am checking how can I solve this issue in the audit in other way

@howjmay howjmay closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgemmsilva jorgemmsilva jorgemmsilva requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howjmay @kape1395 @jorgemmsilva