fix(evm): allow estimateGas with no funds #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+330
to
+332
| if reqctx.vm.task.EstimateGasMode { | ||
| return gasBudget, math.MaxUint64 | ||
| } |
There was a problem hiding this comment.
won't this result in "false positive" estimations?
basically in situations where the estimation would result in insufficient funds for gas * price + value
There was a problem hiding this comment.
Yes, certainly. I don't think there is a solution that fits every use case. I'd imagine that it should be possible to estimate the gas before actually depositing the funds, but we should probably adopt the same behavior than other networks.
cc @fijter
There was a problem hiding this comment.
Even if it's 'wrong' we should do the same thing other networks are doing here yeah :)
jorgemmsilva
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.