Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify restricted addresses in RestrictedAddress type #505

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Unify restricted addresses in RestrictedAddress type #505

merged 7 commits into from
Sep 19, 2023

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Sep 18, 2023 •
edited
Loading

This PR unifies the different RestrictedAddress types into a single one which is basically a container for other address types.

A RestrictedAddress has a capabilities mask which can enable/disable the following features for that address:

  • can receive NativeTokens
  • can receive Mana
  • can receive outputs with TimelockUnlockCondition
  • can receive outputs with ExpirationUnlockCondition
  • can receive outputs with StorageDepositReturnUnlockCondition
  • can receive AccountOutputs
  • can receive NFTOutputs
  • can receive DelegationOutputs

alexsporn
alexsporn reviewed Sep 18, 2023
View reviewed changes
address.go Outdated Show resolved Hide resolved
alexsporn
alexsporn reviewed Sep 18, 2023
View reviewed changes
address_restricted.go Outdated Show resolved Hide resolved
@muXxer muXxer force-pushed the feat/general-restricted-address-type branch from eb56a46 to d327065 Compare September 18, 2023 12:54
Base automatically changed from feat/multi-addresses-unlock to serix-iota-core September 18, 2023 15:36
@muXxer muXxer force-pushed the feat/general-restricted-address-type branch from 8e239d8 to 6afc2e6 Compare September 19, 2023 08:18
@muXxer muXxer force-pushed the feat/general-restricted-address-type branch from 7124235 to d9ca1a6 Compare September 19, 2023 10:26
@muXxer muXxer merged commit 86cc352 into serix-iota-core Sep 19, 2023
@muXxer muXxer deleted the feat/general-restricted-address-type branch September 19, 2023 14:18
@alexsporn alexsporn linked an issue Sep 20, 2023 that may be closed by this pull request
Restricted addresses refactor iotaledger/iota-core#347
Closed
@muXxer muXxer mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippGackstatter PhilippGackstatter PhilippGackstatter approved these changes

@alexsporn alexsporn alexsporn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restricted addresses refactor
3 participants
@muXxer @alexsporn @PhilippGackstatter