Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(doc): create a tutorial for DeFi Lend Borrow solidity contracts #1675

Merged
merged 15 commits into from
Sep 30, 2024
Merged

feat(doc): create a tutorial for DeFi Lend Borrow solidity contracts #1675

merged 15 commits into from
Sep 30, 2024

Conversation

vivekjain23
Copy link
Contributor

Description of change

This PR creates a solidity contract tutorial of DeFi Lend Borrow for the wiki.

Links to any relevant issues

fixes #1665

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@vivekjain23 vivekjain23 changed the title Add part I feat(doc): create tutorial for DeFi Lend Borrow solidity contracts Aug 30, 2024
lucas-tortora
lucas-tortora requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the crosschain marketplace series or yield farming PR.

docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
@lucas-tortora lucas-tortora mentioned this pull request Sep 10, 2024
Merged
4 tasks
@vivekjain23 vivekjain23 marked this pull request as ready for review September 13, 2024 11:30
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 98fdb08

✅ Preview: https://iota-wiki-rj6xfzaco-iota1.vercel.app

lucas-tortora
lucas-tortora requested changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement :)

docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/tutorials/defi-lend-borrow-tutorial-part-1.md Outdated Show resolved Hide resolved
@vivekjain23 vivekjain23 changed the title feat(doc): create tutorial for DeFi Lend Borrow solidity contracts feat(doc): create a tutorial for DeFi Lend Borrow solidity contracts Sep 18, 2024
Ginowine
Ginowine approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Ginowine Ginowine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job bro, well done.

salaheldinsoliman
salaheldinsoliman approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@salaheldinsoliman salaheldinsoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivekjain23 vivekjain23 merged commit 48043ef into main Sep 30, 2024
9 checks passed
@vivekjain23 vivekjain23 deleted the feat/defi-lend-borrow-tutorial branch September 30, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@salaheldinsoliman salaheldinsoliman salaheldinsoliman approved these changes

@Ginowine Ginowine Ginowine approved these changes

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a tutorial for Lending borrowing platform
4 participants
@vivekjain23 @Ginowine @salaheldinsoliman @lucas-tortora