Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call and callView how-to #1516

Merged
merged 41 commits into from
Mar 26, 2024
Merged

Add call and callView how-to #1516

merged 41 commits into from
Mar 26, 2024

Conversation

Dr-Electron
Copy link
Collaborator

Description of change

Added a how-to for calling call and callView of the magic contract. Should be merged after #1512 .

Links to any relevant issues

Fixes #1496

Type of change

  • Documentation Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

lucas-tortora and others added 30 commits March 7, 2024 13:10
…ploy (#1454)

* saving working state

* re-merge EVM and WASM

* apply suggestions by @jlvandenhout

* add simplified explanations in Learn

* add and update get funds
add tabs to tools
delete magic  contract how tos for the time being
add introduction

* first draft deploy a smart contract using remix or hardhat
@todo add images and merge with tools section.

* normalized how we call the ShimmerEVM testnet

* fix links
fix numbering

* rebased on ISC/restructure
saving working state
@todo add dummy value to images
@todo review ERC721 texts and update images

* add how to mint the nft.
create admonition for priorknowledge and remix ide\
delete unnecessary images
align images in ERC20
update sample ERC721 contract
* Add Randomness how-to

* Apply suggestions from code review

Co-authored-by: Lucas Tortora <[email protected]>

---------

Co-authored-by: Lucas Tortora <[email protected]>
* Restructure how-tos

* Update core contract introduction

* Add decimals

* Update docs/build/isc/v1.0.0-rc.6/docs/how-tos/core-contracts/basics/send-assets-to-l1.mdx
* expand gas and allowance explanations

* revert unwanted autoformat change

* Update docs/build/isc/v1.0.0-rc.6/docs/explanations/invocation.md

Co-authored-by: Lucas Tortora <[email protected]>

---------

Co-authored-by: Dr-Electron <[email protected]>
removed glossary tooltip in smart-contract-anatomy.md
clarify that hname identification is only for core and WASM contracts in smart-contract-anatomy.md
removed confusing statement about SC logical structure in smart-contract-anatomy.md
removed video tutorial from tools.mdx
changed serious for production in tools.mdx
rephrased gas/fees statement in tools.mdx
move explanations below how tos in the sidebar
rephrase validator explanation introduction.md
removed link to isc-architecture in introduction.md
removed isc-architecture.md and included what the relevant info in introduction.md
changed md ordered list to html ordered list in tools.mdx to fix the display of the ChainID component
changed Shimmer Public Testnet to Public Testnet on _network_warning.md
removed all video tutorials
@Dr-Electron Dr-Electron linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some punctuation :)

Base automatically changed from wasp-reference-docs to main March 26, 2024 09:57
@Dr-Electron Dr-Electron merged commit a33720b into main Mar 26, 2024
12 checks passed
@Dr-Electron Dr-Electron deleted the call-view branch March 26, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional info to Magic and Core contracts
3 participants