Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rmc and DRR pseudocode in icca wiki #1335

Merged
merged 2 commits into from
Nov 20, 2023
Merged

fix rmc and DRR pseudocode in icca wiki #1335

merged 2 commits into from
Nov 20, 2023

Conversation

cyberphysic4l
Copy link
Contributor

Fix some errors in the congestion control wiki pointed out by a community member on Discord.

vekkiokonio
vekkiokonio reviewed Nov 15, 2023
View reviewed changes
Copy link

@vekkiokonio vekkiokonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated version of the pseudocode has some indentation errors. I suggested some changes. Also, I don't like the continue/break paradigm in pseudocodes

docs/learn/protocols/iota2.0/core-concepts/communication-layer.md Outdated Show resolved Hide resolved
docs/learn/protocols/iota2.0/core-concepts/communication-layer.md Outdated Show resolved Hide resolved
docs/learn/protocols/iota2.0/core-concepts/communication-layer.md Outdated Show resolved Hide resolved
docs/learn/protocols/iota2.0/core-concepts/communication-layer.md Outdated Show resolved Hide resolved
docs/learn/protocols/iota2.0/core-concepts/communication-layer.md Outdated Show resolved Hide resolved
docs/learn/protocols/iota2.0/core-concepts/communication-layer.md Outdated Show resolved Hide resolved
Dr-Electron
Dr-Electron approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Dr-Electron Dr-Electron merged commit 850f787 into main Nov 20, 2023
11 checks passed
@Dr-Electron Dr-Electron deleted the fix/rmc-drr-equations branch November 20, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vekkiokonio vekkiokonio vekkiokonio left review comments

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@Dr-Electron Dr-Electron Dr-Electron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyberphysic4l @vekkiokonio @Dr-Electron @lucas-tortora