Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge wasm bindings #352

Merged
merged 3 commits into from
May 3, 2023
Merged

Merge wasm bindings #352

merged 3 commits into from
May 3, 2023

Conversation

Thoralf-M
Copy link
Member

@Thoralf-M Thoralf-M commented Apr 27, 2023 •
edited
Loading

Currently waiting for a decision on #349

Description of change

Merge wasm bindings

Links to any relevant issues

Closes #141
Closes #369

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Running tests, the nodejs example and also tested it in a web page

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Thoralf-M Thoralf-M force-pushed the wasm-bindings-merge branch 8 times, most recently from 89e6c75 to c83dff3 Compare May 2, 2023 14:36
@Thoralf-M Thoralf-M marked this pull request as ready for review May 2, 2023 14:36
@Thoralf-M Thoralf-M force-pushed the wasm-bindings-merge branch from c83dff3 to c41571d Compare May 2, 2023 14:37
@Thoralf-M Thoralf-M force-pushed the wasm-bindings-merge branch from c9ea675 to 71b5507 Compare May 3, 2023 07:38
@Thoralf-M Thoralf-M force-pushed the wasm-bindings-merge branch from 9ade909 to 8682087 Compare May 3, 2023 16:39
@thibault-martinez thibault-martinez merged commit 071f5b9 into iotaledger:develop May 3, 2023
@Thoralf-M Thoralf-M deleted the wasm-bindings-merge branch May 3, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge wasm bindings Rename AccountManager to Wallet
3 participants
@Thoralf-M @thibault-martinez @DaughterOfMars