-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dedicated EdDSA verifier crate #1238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
added
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Breaking change
A change to the API that requires a major release. Part of "Changed" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
labels
Sep 19, 2023
abdulmth
suggested changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts and some comments.
abdulmth
approved these changes
Sep 21, 2023
eike-hass
approved these changes
Sep 22, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking change
A change to the API that requires a major release. Part of "Changed" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add a dedicated EdDSA verifier crate which contains a single verifier for curve
Ed25519
but could be extended non-breakingly to also supportEd448
later. Other verifier crates could be nicely added alongside it.This PR also makes the validators fully agnostic over the verifier and not rely on the EdDSA JWS Verifier as the default. Previously the verifier was required even when not using it due to how we used generics. That was changed and the validation methods that don't rely on a verifier were moved to "Util" namespaces. The same applies to the Wasm bindings.
Links to any relevant issues
n/a
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Existing tests & clippy.
Change checklist
Add an
x
to the boxes that are relevant to your changes.