Qc fixes #401
Open
Qc fixes #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sues(dac_qc_comment)
Improved or added Docstring to function, method, or class Used the logging module to log message at the error level Added a report to functions' returns to log in the error Used fill_value=np.int16(-999) for _FillValue for qartod variables. Using a flag value to _FillValue is not a good practice for quality control data. Add a full array of 2 as a default for qartod variables. There are instances where array cannot be qc tested because of errors in attributes values or there are insufficient data or the array is empty. Add a functionality to drop configuration specifications and skip QC if the specs cannot be calculated. This is for the function get_spike_thresholds and get_rate_of_change_threshold Changed the qartod method to calculate flags from XarrayStream to PandasStream to fix the array type compatability issues with the ioos-qc module. Added the values mask check and invalis data check to the time array.
added the suspect_span to the density gross_range_test
benjwadams
previously approved these changes
Dec 2, 2024
benjwadams
requested changes
Dec 2, 2024
minor fix to work with test_glider_qc.py
adjusted functions to match those of the reworked glider_qc.py
fixed glider_qc/glider_qc.py:140: NameError: name 'ncfile' is not defined line
fixed tests/test_glider_qc.py:119: NameError: name 'normalize_variable' is not defined fixed tests/test_glider_qc.py:75: KeyError: 'gross_range_test'
Fixed tests/test_glider_qc.py:73: NameError: name 'tempvar' is not defined
Fixed tests/test_glider_qc.py:84: KeyError: 'gross_range_test'
This was
linked to
issues
Dec 19, 2024
The unit tests were checked and modified to work with the new updates/changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update of the glider_qc.py module and functions