Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rate_of_change_test flags are corrupted when the time array is in nano seconds #376

Open
leilabbb opened this issue Sep 4, 2024 · 3 comments · May be fixed by #401
Open

rate_of_change_test flags are corrupted when the time array is in nano seconds #376

leilabbb opened this issue Sep 4, 2024 · 3 comments · May be fixed by #401

Comments

@leilabbb
Copy link
Contributor

leilabbb commented Sep 4, 2024

The QARTOD rate_of_change_test expects time in seconds. When the time array uses a different data type the array needs to be tested and a conversion needs to be applied for consistency.

The time data type also affects the threshold calculation in the glider_qc.py. An alternative method is tested to render a more reliable value for the threshold.

This notebook tests the modifications needed for the threshold calculation and applies them to a NetCDF file.

Data annotation will be added to the file to notify users. This is part of the issue #365

@benjwadams
Copy link
Contributor

Nanoseconds aren't accepted by ERDDAP, either. May be an issue because it appears to be valid UDUnits.

@leilabbb
Copy link
Contributor Author

leilabbb commented Nov 13, 2024

A draft pull request with a new conditional statement was created to check time units .

@leilabbb leilabbb linked a pull request Dec 19, 2024 that will close this issue
@leilabbb
Copy link
Contributor Author

This is addressed in pull request #401. See the function get_rate_of_change_threshold, which reports on the variable's issues.

The time format times[:].astype('datetime64[s]') is now used in the function run_qc to resolve the problem with the rate_of_change_test flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants