Configurable classes for ACL objects and models #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR, I'll take a look at it. Anyways I can't merge in a PR with failing tests: could you try to fix them? Thank you |
|
I fix some disputable moment |
|
Thank you for your PR I'll take a look at it |
|
Can you rebase -i to merge multiple commits into one single commit please? 😄 |
TeryaevNikita
force-pushed
the
customize_tablename
branch
from
7d85d55 to
73723fd
Compare
|
done :) |
|
anything else ? |
|
Sorry was busy. I'll take a look at it asap 😄 |
|
+1, add it please |
|
Any reason why this is still yet to be merged ? @TeryaevNikita @intrip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability for inheritance and customization of base classes and models. It is necessary for projects with custom users table name and own User class.