Remove nsjsonserialization #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
In general, pull requests should only do one thing. If all this PR did was remove NSJSONSerialization, it would already be merge. |
|
I guess I didn't do a |
djberg96
changed the title
|
Can you please fixup these commits so there's only one? |
djberg96
force-pushed
the
remove_nsjonserialization
branch
from
950d002 to
24e8ac3
Compare
|
@sferik ok done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon further review, nsjsonserialization was for MacRuby, which is long defunct:
https://github.com/MacRuby/MacRuby/blob/master/README.rdoc
https://developer.apple.com/documentation/foundation/nsjsonserialization
There is something called RubyMotion, but beyond some failed tinkering I've never really tried it, nor am I sure it would use the nsjsonserialization adapter anyway, as it's apparently more of a cross-platform environment for mobile apps. So, unless there's any objection, I think it's best to just remove it.
While I was here I fixed the Rakefile. There is no "standard/rake" that I'm aware of, and that fails for me locally. It's just "rake".