LogicValue radixString uses underscore separators by default #535
+118
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
reviewed
Dec 27, 2024
| @@ -0,0 +1,19 @@ | |||
| // Copyright (C) 2023 Intel Corporation | |||
| @@ -724,6 +727,10 @@ abstract class LogicValue implements Comparable<LogicValue> { | |||
| /// radix format. Space-separation is for ease of reading and is often | |||
| /// in chunks of 4 digits. | |||
| /// | |||
| /// If the format of then length/radix-encoded string is not completely parsed | |||
| /// an exception will be thrown. This can be caused by illegal characters | |||
| /// in the string or too short or too long of a value string. | |||
There was a problem hiding this comment.
what would be an example of too short? wouldn't it 0-pad?
| try { | ||
| LogicValue.ofRadixString("10'b10 0010_0111"); | ||
| } on Exception catch (e) { | ||
| expect(e.runtimeType, LogicValueConstructionException); |
There was a problem hiding this comment.
i think the typical pattern for this is expect(e, isA<LogicValueConstructionException>())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Added an option to LogicValue.toRadixString and .ofRadixString to use '_' as a default separator, but allow
for the user to specify a different separator.
Related Issue(s)
#534
Testing
Converted tests to use _ as separator after testing with sepChar argument.
Backwards-compatibility
Yes. Previously output radixStrings will not parse by default as they will have spaces.
Documentation
Documentation in the class code is now up to date with this change.