Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Encode] Fix some coverity issues exposed in encode #351

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Bossonor
Copy link
Contributor

@Bossonor Bossonor commented Nov 10, 2023

Fix some encode coverity issues: 11 Unchecked return value; 5 Dead code; 4 Resource leak; 3 Modulo by zero; 1 Argument cannot be negative; 1 Out-of-bounds write

Signed-off-by: Chen, Bohan [email protected]

encode/avcenc.c Outdated Show resolved Hide resolved
encode/hevcencode.c Show resolved Hide resolved
encode/hevcencode.c Outdated Show resolved Hide resolved
encode/hevcencode.c Outdated Show resolved Hide resolved
encode/jpegenc.c Outdated Show resolved Hide resolved
encode/vp9enc.c Outdated Show resolved Hide resolved
encode/av1encode.c Show resolved Hide resolved
@Bossonor Bossonor changed the title [Encode] Fix coverity issues [Encode] Fix some coverity issues exposed in encode Nov 13, 2023
Copy link

@DaShi-Git DaShi-Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XinfengZhang
Copy link
Contributor

commit message should include:
title:
description:
signoff:

please use "git commit --signoff --amend" to change your commit message

@Bossonor
Copy link
Contributor Author

commit message should include: title: description: signoff:

please use "git commit --signoff --amend" to change your commit message

Already resubmit commit message, thanks!

encode/av1encode.c Outdated Show resolved Hide resolved
encode/av1encode.c Outdated Show resolved Hide resolved
encode/av1encode.c Outdated Show resolved Hide resolved
@Bossonor
Copy link
Contributor Author

/build

encode/av1encode.c Outdated Show resolved Hide resolved
encode/av1encode.c Outdated Show resolved Hide resolved
encode/av1encode.c Outdated Show resolved Hide resolved
encode/av1encode.c Outdated Show resolved Hide resolved
encode/av1encode.c Show resolved Hide resolved
Fix some encode coverity issues: 11 Unchecked return value; 5 Dead code; 4 Resource leak; 3 Modulo by zero; 1 Argument cannot be negative; 1 Out-of-bounds write

Signed-off-by: Chen, Bohan <[email protected]>
Copy link
Contributor

@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@XinfengZhang XinfengZhang merged commit 505e7b3 into intel:master Nov 30, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants