Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #684 Merge results from main and derived catalogs #685

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

rbeucher
Copy link
Collaborator

@rbeucher rbeucher commented Nov 1, 2024

Change Summary

drop_duplicates does not work on dataframe that contains lists. This causes issue #684.

Will close #684

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@rbeucher rbeucher requested a review from mgrover1 as a code owner November 1, 2024 04:03
@rbeucher rbeucher requested review from charles-turner-1 and removed request for mgrover1 November 1, 2024 04:08
@charles-turner-1
Copy link
Collaborator

Same RTD issue as: #681 (review)

intake_esm/core.py Show resolved Hide resolved
@rbeucher rbeucher merged commit 9db6ad6 into main Nov 1, 2024
8 of 9 checks passed
@rbeucher rbeucher deleted the bugfix-684-derived-variables-from-iterables branch November 1, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog search on derived variable fails if the variable column is iterable.
2 participants