Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improved local test running #1441

Merged
merged 4 commits into from
Nov 12, 2024
Merged

test: improved local test running #1441

merged 4 commits into from
Nov 12, 2024

Conversation

kirrg001
Copy link
Contributor

  • Added node script to add terminal aliases
  • Integrate mocha --watch
  • Removed redundant sh helper scripts. Only one sh helper script bin/run-tests.sh.

See CONTRIBUTING.md.

@kirrg001 kirrg001 requested a review from a team as a code owner November 11, 2024 11:00
@kirrg001
Copy link
Contributor Author

There is one problem with the cleanup of our global agent and --watch in our test env.

@kirrg001
Copy link
Contributor Author

refs mochajs/mocha#5149

@kirrg001
Copy link
Contributor Author

Fixed 586cd0a

Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Add aliases to your terminal:

```sh
node bin/add-test-aliases.js bash|zsh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node bin/add-test-aliases.js bash worked for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified in zsh.

node bin/add-test-aliases.js zsh worked fine for me!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
kirrg001 and others added 4 commits November 12, 2024 08:33
- node script to add aliases
- integrate mocha watch
- removed redundant sh helper scripts
@kirrg001 kirrg001 merged commit f60f3e0 into main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants