Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inspector] Expose event in onStateChanged event. #316

Merged
merged 2 commits into from
Dec 6, 2023
Merged

[Inspector] Expose event in onStateChanged event. #316

merged 2 commits into from
Dec 6, 2023

Conversation

Laimiux
Copy link
Collaborator

@Laimiux Laimiux commented Dec 6, 2023

What

In Inspector, we want to see what event triggers an evaluation.

@Laimiux Laimiux requested a review from jhowens89 December 6, 2023 18:33
@carrotkite
Copy link

JaCoCo Code Coverage 79.49% ✅

Class Covered Meta Status
com/instacart/formula/internal/ListInspector 81% 0% ✅
com/instacart/formula/internal/SnapshotImpl 81% 0% ✅
com/instacart/formula/internal/FormulaManagerImpl 87% 0% ✅
com/instacart/formula/test/CountingInspector 70% 0% ✅

Generated by 🚫 Danger

@Laimiux Laimiux merged commit 6374812 into master Dec 6, 2023
5 checks passed
@Laimiux Laimiux deleted the laimonas/expose-event branch December 6, 2023 19:06
Laimiux added a commit that referenced this pull request Jan 26, 2024
@Laimiux
[Inspector] Expose event in onStateChanged event. (#316)
aa6453e 
* [Inspector] Expose event in onStateChanged event.

* Fix test compilation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhowens89 jhowens89 jhowens89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Laimiux @carrotkite @jhowens89