refactor: Move common Swift and Lua into OpoLuaCore #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new OpoLuaCore Swift package which contains the common Lua code and relevant Swift wrappers which were previously in 'swift'. It's not at all clear to me if this is the correct approach, but it's here for discussion---this would make it easier to slowly pull common (non-AppKit/UIKit) code into a core package and allow us to incrementally move towards code that could be shared between native iOS and macOS apps. What I don't like about this change is that it moves the potentially very cross-platform Lua code firmly into a Swift package, potentially making it more fiddly to add other !Apple platforms in the future. Unfortunately, excepting symlinks, I can't think of a way to include the Lua 'src' directory in the OpoLuaCore package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new OpoLuaCore Swift package which contains the common Lua code and relevant Swift wrappers which were previously in 'swift'.
It's not at all clear to me if this is the correct approach, but it's here for discussion---this would make it easier to slowly pull common (non-AppKit/UIKit) code into a core package and allow us to incrementally move towards code that could be shared between native iOS and macOS apps. What I don't like about this change is that it moves the potentially very cross-platform Lua code firmly into a Swift package, potentially making it more fiddly to add other !Apple platforms in the future. Unfortunately, excepting symlinks, I can't think of a way to include the Lua 'src' directory in the OpoLuaCore package.