Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix downloading of stable explorer when publishing to pages #2186

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Dec 18, 2024

Content

This PR fix the stable explored download step in the publish_docs job, the github secret token was missing in order to use gh cli.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2172

The github secret token was missing in order to use `gh` cli.
@Alenar Alenar added bug ⚠️ Something isn't working CI/CD 🏭 CI/CD labels Dec 18, 2024
@Alenar Alenar self-assigned this Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

Test Results

    4 files  ±0     52 suites  ±0   9m 54s ⏱️ -1s
1 432 tests ±0  1 432 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 643 runs  ±0  1 643 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a485ddc. ± Comparison against base commit 675233f.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview December 18, 2024 10:48 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet December 18, 2024 10:48 — with GitHub Actions Inactive
@Alenar Alenar merged commit d106a3f into main Dec 18, 2024
54 of 57 checks passed
@Alenar Alenar deleted the djo/2172/use-released-build-for-stable-explorer-fix branch December 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ Something isn't working CI/CD 🏭 CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants