Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish packaged explorer in latest release #2185

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Dec 17, 2024

Content

This PR swap the packaged explorer that's published in our github pages.
Now the package deployed is fetched from our latest released instead of using the one built in the build-test-explorer job (that we still need since it's used in (pre-)releases).

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2172

@Alenar Alenar self-assigned this Dec 17, 2024
Instead of relying on the one built in the `build-test-explorer` job
(that we still need since it's used in (pre-)releases).
@Alenar Alenar force-pushed the djo/2172/use-released-build-for-stable-explorer branch from b48d0f1 to a98448c Compare December 17, 2024 16:46
Copy link

Test Results

    4 files  ±0     52 suites  ±0   9m 45s ⏱️ -12s
1 432 tests ±0  1 432 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 643 runs  ±0  1 643 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a98448c. ± Comparison against base commit 4940dd3.

@Alenar Alenar temporarily deployed to testing-preview December 17, 2024 16:57 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet December 17, 2024 16:57 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar merged commit 675233f into main Dec 18, 2024
51 of 54 checks passed
@Alenar Alenar deleted the djo/2172/use-released-build-for-stable-explorer branch December 18, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stable and unstable versions of the explorer
4 participants