-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accelerate signer fixtures creation in tests #2161
Accelerate signer fixtures creation in tests #2161
Conversation
680ef13
to
e797ece
Compare
06a9710
to
a167bac
Compare
35f45e5
to
c71819a
Compare
c71819a
to
2dc1c26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Can you add a brief summary about how much this accelerates the performances of the fixture creation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍, just minor suggestions.
* mithril-aggregator from `0.5.121` to `0.5.122` * mithril-common from `0.4.94` to `0.4.95`
a75319d
to
38314fe
Compare
Content
Cryptographic operations takes a long time when we creating signers in tests.
To reduce this time, we precompute keskey for some party ids.
This PR stores in a file precomputed keskey for some party ids and use them if they match with the party id to create.
A test check that all keys are precomputed up to a party id number.
If precomputed keys are differents from the real ones, the test output the code to copy in function that provide precomputed keys.
Important
The directory
/tmp/mithril_crypto_helper_material
have to be removed to not reuse oldkes.sk
andopcert.cert
files.Time observed on the local environment before and after this PR.
Pre-submit checklist
Issue(s)
Closes #2153