Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update dependencies for distribution 2450 #2157

Merged
merged 14 commits into from
Dec 9, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Dec 3, 2024

Content

This PR upgrades the repository dependencies to their latest version in preparation of the distribution 2449 by running the upgrade script from the runbook.

Security enhancements:

Dependency updates:

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2124

@jpraynaud jpraynaud self-assigned this Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Test Results

    4 files  ±0     52 suites  ±0   11m 58s ⏱️ +14s
1 428 tests ±0  1 428 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 639 runs  ±0  1 639 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8aeaf9e. ± Comparison against base commit 5d1cbea.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2124-upgrade-dependencies-distribution-2448 branch from c5e38bd to 8d48312 Compare December 3, 2024 14:57
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 3, 2024 15:12 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2124-upgrade-dependencies-distribution-2448 branch from 8d48312 to 44bb83a Compare December 4, 2024 12:08
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 4, 2024 13:43 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2124-upgrade-dependencies-distribution-2448 branch from 44bb83a to cd10d58 Compare December 5, 2024 10:25
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 5, 2024 10:40 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2124-upgrade-dependencies-distribution-2448 branch from cd10d58 to fd3df81 Compare December 5, 2024 11:25
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 5, 2024 11:42 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review December 5, 2024 11:43
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.
We just need to update the generated commit message (not necessarily in this PR) in upgrade_dependencies.sh and the associated README.md by replacing:

- 'make www-install' command in 'mithril-client-wasm'.
- 'make www-test-install' command in 'mithril-client-wasm'.

with:

- 'make install' command in 'examples/client-wasm-web'.
- 'make install' command in 'examples/client-wasm-nodejs'.

@jpraynaud jpraynaud force-pushed the jpraynaud/2124-upgrade-dependencies-distribution-2448 branch from fd3df81 to 6703912 Compare December 5, 2024 13:53
@jpraynaud
Copy link
Member Author

LGTM 👍. We just need to update the generated commit message (not necessarily in this PR) in upgrade_dependencies.sh and the associated README.md by replacing:

- 'make www-install' command in 'mithril-client-wasm'.
- 'make www-test-install' command in 'mithril-client-wasm'.

with:

- 'make install' command in 'examples/client-wasm-web'.
- 'make install' command in 'examples/client-wasm-nodejs'.

Good catch 👍
Done in ab75be5

@jpraynaud jpraynaud changed the title Chore: update dependencies for distribution 2448 Chore: update dependencies for distribution 2449 Dec 5, 2024
@jpraynaud jpraynaud changed the title Chore: update dependencies for distribution 2449 Chore: update dependencies for distribution 2450 Dec 6, 2024
@jpraynaud jpraynaud force-pushed the jpraynaud/2124-upgrade-dependencies-distribution-2448 branch from 6703912 to e5617c2 Compare December 6, 2024 09:10
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 6, 2024 09:29 — with GitHub Actions Inactive
Update misisng official docusaurus plugins.
To avoid dependencies conflicts on react.
To avoid dependencies conflicts on reactwq.
By running 'make upgrade' command.
By running 'make upgrade-ci-test-deps' command.
By running 'make upgrade' command in 'examples/client-wasm-nodejs' and 'examples/client-wasm-web'.
By running 'make upgrade' command.
By running:
- 'make install' command in 'examples/client-wasm-web'.
- 'make install' command in 'examples/client-wasm-nodejs'.
- 'make install' command in 'mithril-explorer'.
- 'make install' command in 'docs/website'.
 By running 'nix flake update' command.
@jpraynaud jpraynaud force-pushed the jpraynaud/2124-upgrade-dependencies-distribution-2448 branch from e5617c2 to 8aeaf9e Compare December 6, 2024 13:56
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 6, 2024 14:21 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit f1441bc into main Dec 9, 2024
51 of 58 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2124-upgrade-dependencies-distribution-2448 branch December 9, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants