Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: create new signed entity type for Incremental Cardano DB #2142

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Feat: create new signed entity type for Incremental Cardano DB #2142

merged 8 commits into from
Nov 26, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Nov 25, 2024 •
edited
Loading

Content

This PR implements a new signed entity type, CardanoDatabase, for the incremental Cardano database signature.

The use of panics with todo!() or unimplemented!() has been avoided in the SignableBuilder and the compute_artifact function in favor of returning errors instead.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2121

@dlachaume dlachaume self-assigned this Nov 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

Test Results

    4 files  ±0     51 suites  ±0   11m 37s ⏱️ -7s
1 459 tests +4  1 459 ✅ +4  0 💤 ±0  0 ❌ ±0 
1 670 runs  +4  1 670 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 8fb92fa. ± Comparison against base commit 67d7501.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume marked this pull request as ready for review November 25, 2024 15:35
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 25, 2024 15:35 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Regarding the panics:

  • either we replace them by logs when returning an error is not an option and we can merge this PR right away
  • or we keep them, but we don't merge this PR until there is a PR that removes them

mithril-common/src/entities/signed_entity_type.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/signed_entity_type.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 25, 2024 16:11 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 25, 2024 16:27 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 25, 2024 17:25 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Nov 25, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 25, 2024 17:49 — with GitHub Actions Inactive
@dlachaume
chore: reference the feature in the CHANGELOG
d539f13
@dlachaume
chore: upgrade crate versions
8fb92fa 
* mithril-persistence from `0.2.35` to `0.2.36`
* mithril-aggregator from `0.5.113` to `0.5.114`
* mithril-common from `0.4.88` to `0.4.89`
* mithril-signer from `0.2.115` to `0.2.116`
@dlachaume dlachaume force-pushed the dlachaume/2121/create-new-signed-entity-type-for-incremental-cardano-db branch from 3c27439 to 8fb92fa Compare November 26, 2024 08:21
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 26, 2024 08:32 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit 94495a4 into main Nov 26, 2024
50 checks passed
@dlachaume dlachaume deleted the dlachaume/2121/create-new-signed-entity-type-for-incremental-cardano-db branch November 26, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel sfauvel approved these changes

@Alenar Alenar Alenar approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new signed entity type for Incremental Cardano DB
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud